chore: adjust precomputed assignments export for node environment #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mputed client is hard coded to expect an obfuscated input
sameerank
commented
Jan 9, 2025
| @@ -871,7 +871,7 @@ export default class EppoClient { | |||
| getPrecomputedAssignments( | |||
| subjectKey: string, | |||
| subjectAttributes: Attributes | ContextAttributes = {}, | |||
| obfuscated = false, | |||
| obfuscated = true, | |||
There was a problem hiding this comment.
This is hard coded to be true in other places in the common sdk, e.g.
So at the very least, the default here should be true if we let it support both formats
There was a problem hiding this comment.
#180 will drop support for this param.
sameerank
commented
Jan 9, 2025
src/obfuscation.ts
Outdated
Comment on lines
8
to
22
| let getRandomValues: (length: number) => Uint8Array; | ||
| if (typeof window !== 'undefined' && window.crypto) { | ||
| // Browser environment | ||
| getRandomValues = (length: number) => window.crypto.getRandomValues(new Uint8Array(length)); | ||
| } else { | ||
| // Node.js environment | ||
| import('crypto') | ||
| .then((crypto) => { | ||
| getRandomValues = (length: number) => new Uint8Array(crypto.randomBytes(length)); | ||
| return; | ||
| }) | ||
| .catch((error) => { | ||
| logger.error('Failed to load crypto module:', error); | ||
| }); | ||
| } |
There was a problem hiding this comment.
crypto isn't a global variable in the node environment and needs to be imported. Additional work will need to be done here to also make this work in react native.
Is there a better way to do this? Open to suggestions
There was a problem hiding this comment.
thanks for mentioning react native. could you please add support now as i'll need to dogfood it. chatgpt suggests:
let getRandomValues: (length: number) => Uint8Array;
if (typeof window !== 'undefined' && window.crypto?.getRandomValues) {
// Browser environment
getRandomValues = (length: number) => window.crypto.getRandomValues(new Uint8Array(length));
} else if (typeof navigator !== 'undefined' && navigator.product === 'ReactNative') {
// React Native environment (using react-native-get-random-values)
import('react-native-get-random-values').then(() => {
getRandomValues = (length: number) => {
const array = new Uint8Array(length);
return window.crypto.getRandomValues(array);
};
});
} else {
// Node.js environment
import('crypto')
.then((crypto) => {
getRandomValues = (length: number) => new Uint8Array(crypto.randomBytes(length));
})
.catch((error) => {
console.error('Failed to load crypto module:', error);
throw new Error('Crypto module is required in Node.js');
});
}
// Export function for use in the library
export { getRandomValues };
the eppo react native sdk will add react-native-get-random-values as a dependency
sameerank
commented
Jan 9, 2025
Comment on lines
+132
to
+133
| setSaltOverrideForTests, | ||
| decodePrecomputedFlag, |
leoromanovsky
approved these changes
Jan 9, 2025
| @@ -19,6 +19,9 @@ module.exports = { | |||
| }, | |||
| resolve: { | |||
| extensions: ['.tsx', '.ts', '.js'], | |||
| fallback: { | |||
| crypto: false, // Exclude crypto module in the browser bundle | |||
src/obfuscation.ts
Outdated
Comment on lines
8
to
22
| let getRandomValues: (length: number) => Uint8Array; | ||
| if (typeof window !== 'undefined' && window.crypto) { | ||
| // Browser environment | ||
| getRandomValues = (length: number) => window.crypto.getRandomValues(new Uint8Array(length)); | ||
| } else { | ||
| // Node.js environment | ||
| import('crypto') | ||
| .then((crypto) => { | ||
| getRandomValues = (length: number) => new Uint8Array(crypto.randomBytes(length)); | ||
| return; | ||
| }) | ||
| .catch((error) => { | ||
| logger.error('Failed to load crypto module:', error); | ||
| }); | ||
| } |
There was a problem hiding this comment.
thanks for mentioning react native. could you please add support now as i'll need to dogfood it. chatgpt suggests:
let getRandomValues: (length: number) => Uint8Array;
if (typeof window !== 'undefined' && window.crypto?.getRandomValues) {
// Browser environment
getRandomValues = (length: number) => window.crypto.getRandomValues(new Uint8Array(length));
} else if (typeof navigator !== 'undefined' && navigator.product === 'ReactNative') {
// React Native environment (using react-native-get-random-values)
import('react-native-get-random-values').then(() => {
getRandomValues = (length: number) => {
const array = new Uint8Array(length);
return window.crypto.getRandomValues(array);
};
});
} else {
// Node.js environment
import('crypto')
.then((crypto) => {
getRandomValues = (length: number) => new Uint8Array(crypto.randomBytes(length));
})
.catch((error) => {
console.error('Failed to load crypto module:', error);
throw new Error('Crypto module is required in Node.js');
});
}
// Export function for use in the library
export { getRandomValues };
the eppo react native sdk will add react-native-get-random-values as a dependency
typotter
approved these changes
Jan 9, 2025
sameerank
deleted the
sameeran/ff-3785-export-precomputed-configuration-wire-in-node-sdk
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labels: mergeable
Fixes: #issue
Motivation and Context
Description
A method for exporting precomputed assignments was added to the common sdk #160 and published in version 4.7.1
The end-user would use the function in the node SDK and so I checked that it works in the node environment. I found a couple things to improve:
cryptoneeds to be imported in node, the common sdk assumes it is a globally scoped variable which is only true in the browser environmentHow has this been tested?
Locally with
yarn linkand running the test I created in Eppo-exp/node-server-sdk#89